-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/nbs #36
Bugfix/nbs #36
Conversation
New warnings found with rstcheck:
|
180939e
to
10adb6b
Compare
New warnings found with rstcheck:
|
Huh. So it appears that rstcheck doesn't know how to parse the standard substitution lists. |
This PR now upgrades rstcheck to a version that can actually parse standard include directives. |
New warnings found with rstcheck:
|
@StaticRocket Why does it hunts for g++? |
It's part of the code block checking. It uses GCC to check if a code block is actually valid C, if it's been tagged as C. Unfortunately most of our code blocks are just snippets with invalid syntax like lines of If you see the commit log, one commit changes this config file key since the newer version of rstcheck doesn't use that key. The new config was picked up by the old workflow so it brings this error up. |
8c68664
to
329b49c
Compare
New warnings found with rstcheck:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what, let me split this PR. Package upgrades should be independent of this. |
Will rebase this once #61 is merged. This will make the CI checks happy. |
667162f
to
2a7f2bd
Compare
New warnings found with rstcheck:
|
2a7f2bd
to
8f7ef71
Compare
New warnings found with rstcheck:
|
8f7ef71
to
0d0f08b
Compare
New warnings found with rstcheck:
|
0d0f08b
to
9135359
Compare
New warnings found with rstcheck:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve merge conflicts
Found a lot of non-breaking spaces in places where they were not needed. Replace them with spaces and fix the resulting whitespace errors. Out of curiosity I was scanning the docs for any non-ascii characters to see if there is anything that could be breaking formatting that standard mechanisms wouldn't catch. Found all of this. Assume it was from the initial import from the processor wiki. Signed-off-by: Randolph Sapp <[email protected]>
Use standard I2C notation instead of using the unicode power of 2 symbol. Signed-off-by: Randolph Sapp <[email protected]>
Use ascii vertical bar instead of the unicode broken bar symbol. Signed-off-by: Randolph Sapp <[email protected]>
9135359
to
59e2a26
Compare
Fix various style issues and odd character usage that may affect rst parsers.